feat: in-place task restart on recoverable task failure#7093
Open
AdilFayyaz wants to merge 2 commits intov2from
Open
feat: in-place task restart on recoverable task failure#7093AdilFayyaz wants to merge 2 commits intov2from
AdilFayyaz wants to merge 2 commits intov2from
Conversation
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
pingsutw
reviewed
Mar 25, 2026
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When a task pod fails with a recoverable error, the executor relied on the runs service to create a new TaskAction CR for each retry. This external orchestration was broken, leaving retryable tasks stuck in a non-terminal RetryableFailure loop indefinitely.
What changes were proposed in this pull request?
How was this patch tested?
[name]-0, [name]-1, [name]-2are each created and deleted in sequence:kubectl get pods -n [namespace] | grep [taskaction-name]kubectl get taskaction [name] -n [namespace] -o jsonpath='{.status.attempts}'kubectl get taskaction [name] -n [namespace] -o jsonpath='{.status.conditions}'Failed=True, Reason=PermanentFailure
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main